Skip to content

feat: add debug CRL refresh controls [WPB-24945]#4839

Merged
Garzas merged 3 commits into
developfrom
feat/crl-debug-expiration
May 21, 2026
Merged

feat: add debug CRL refresh controls [WPB-24945]#4839
Garzas merged 3 commits into
developfrom
feat/crl-debug-expiration

Conversation

@Garzas

@Garzas Garzas commented May 19, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-24945

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Adds a private debug setting for testing E2EI CRL revocation updates faster than the normal CRL expiry cycle.

QA needs a way to force CRLs to expire quickly so revoked certificates can be detected without waiting up to 24 hours.

Causes (Optional)

The existing CRL revocation check button could trigger a manual check, but there was no working debug control that kept CRL expiry short for repeated testing.

Solutions

Adds a Force CRL expiry after 1 minute switch in private debug tools.

When enabled, the app:

  • enables the debug CRL expiry override
  • immediately triggers a forced CRL check
  • reduces the foreground CRL check throttle from 60 minutes to 1 minute while the switch is enabled

When disabled, the app stops using the debug expiry behavior and returns to the normal CRL expiry flow.

@Garzas Garzas self-assigned this May 19, 2026
@Garzas Garzas force-pushed the feat/crl-debug-expiration branch from be7e43a to f19cb1b Compare May 20, 2026 06:58
@sonarqubecloud

sonarqubecloud Bot commented May 21, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

@Garzas looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
122f2bd1c5e31459d5d090aeeee0a808064a5ef1 d62cb852afb2815902e1d61041d884c561e5f286

Is this intentional?

@Garzas Garzas enabled auto-merge May 21, 2026 10:22
@codecov

codecov Bot commented May 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.29%. Comparing base (9341b52) to head (1381efb).

Files with missing lines Patch % Lines
...wire/android/ui/debug/DebugDataOptionsViewModel.kt 81.81% 1 Missing and 1 partial ⚠️
...otlin/com/wire/android/ui/home/AppSyncViewModel.kt 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #4839      +/-   ##
===========================================
+ Coverage    51.26%   51.29%   +0.02%     
===========================================
  Files          611      611              
  Lines        21181    21201      +20     
  Branches      3405     3407       +2     
===========================================
+ Hits         10859    10875      +16     
- Misses        9308     9310       +2     
- Partials      1014     1016       +2
Files with missing lines Coverage Δ
...com/wire/android/ui/debug/DebugDataOptionsState.kt 100.00% <100.00%> (ø)
...wire/android/ui/debug/DebugDataOptionsViewModel.kt 56.28% <81.81%> (+1.49%) ⬆️
...otlin/com/wire/android/ui/home/AppSyncViewModel.kt 76.00% <77.77%> (-0.48%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9341b52...1381efb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Garzas Garzas added this pull request to the merge queue May 21, 2026
Merged via the queue into develop with commit d7e2257 May 21, 2026
16 checks passed
@Garzas Garzas deleted the feat/crl-debug-expiration branch May 21, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbakhtiarov sbakhtiarov sbakhtiarov approved these changes

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@yamilmedina yamilmedina Awaiting requested review from yamilmedina

Assignees

@Garzas Garzas

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Garzas @sbakhtiarov @MohamadJaara